Fix potentially ambiguous .as_ref()
#1062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1017 was reported as a breaking change made to
rustls
. This isn't really the case. The true culprit is this vague.as_ref()
call.In general, it is allowed to change a fn that used to take
T
to now takeimpl Trait
whereT: Trait
.AsRef
is an unfortunate example of a trait that is often misused like this.There may be more of these cases, if possible they should be switched so that a new
AsRef
impl or change such as was made inrustls
doesn't break downstreams again.