Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop requiring error kinds to impl Display #1066

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop requiring error kinds to impl Display #1066

wants to merge 1 commit into from

Commits on Sep 29, 2023

  1. Stop requiring error kinds to impl Display 

    All kinds of `error::Error` now implements the `Display` trait,
and the `Display` for the `Error` itself is inherited.

The binding between the kind and `Display` is not necessary though.

In this commit I dropped the restriction of error kinds by `Display`,
and only implemented the trait for errors with displayable kinds.
As a result, the developer got 2 options:

- either to implement the `Display` for the kind (preferred),
- or implement it for the error only (but not for the kind) (edge case).
    @nepalez
    nepalez committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    caaf5da View commit details
    Browse the repository at this point in the history