Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need for manual flushing almost entirely.
What it does, is instead of relying on a timer, it tracks the number of pending
Commands
to be sent.If there are no pending Commands, it's a slow traffic scenario, and the client flushes the data immediately.
If there are pending Commands, it buffers the data until buffer size is reached or pending commands reach 0.
Unfortunately,
tokio::sync::mpsc
does not allow checking how many messages are pending in the channel, hence the use of AtomicU64.This can definitely by improved by replacing channels by some other shared state or simply another mpsc equivalent.
This is a quick check how this solution would perform.
benchmarks: