Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service defaults #1150

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Fix service defaults #1150

merged 4 commits into from
Nov 2, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Nov 2, 2023

After recent changes in main, some schema validations are failing if defaut values are provided.

fixes #1149
fixes #1148

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema requested a review from piotrpio November 2, 2023 09:23
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit 67b2798 into main Nov 2, 2023
10 checks passed
@Jarema Jarema deleted the fix-service-defaults branch November 2, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants