Don't expose BoxFuture in public API #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these futures are borrowing anything from outside their Box, so their lifetimes can be 'static. This avoids polluting a bunch of public types with unnecessary lifetime parameters.
`ObjectStore::get` calls itself recursively, so the returned future needs to be boxed. However, this is an implementation detail, there's no reason to expose it in the public API. Instead, we can move the recursive call to a separate `get_impl` function that handles the boxing, and `get` can just be a standard async function.
oscarwcl
force-pushed
the
no-public-boxfuture
branch
from
fa4324a
to
196437f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1166
ObjectStore::getcalls itself recursively, so the returned future needs to be boxed. However, this is an implementation detail, there's no reason to expose it in the public API. Instead, we can move the recursive call to a separateget_implfunction that handles the boxing, andgetcan just be a standard async function.This is a minor stylistic change, but if it's desired it makes sense to land it at the same time as #1166 since that is already a breaking change.