Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clone in message split method #1172

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove clone in message split method #1172

merged 1 commit into from
Dec 7, 2023

Conversation

AbstractiveNord
Copy link
Contributor

Now split method use owned self, not reference.

@AbstractiveNord
Remove clone in message split method
dffeb8c 
Now split method use owned self, not reference.
@Jarema Jarema self-requested a review December 7, 2023 12:13
Jarema
Jarema approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cloning reply is not an expensive operation, as Subject is held as Bytes meaning that it's just ref counting, but it's always nice to improve!

Thanks for your contribution!

@Jarema Jarema merged commit 42bc64f into nats-io:main Dec 7, 2023
11 checks passed
@Jarema Jarema mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbstractiveNord @Jarema