fix: ensure the ping interval waker is registered #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an interval is ready it does not need to register its internal waker, leading to the future not being polled anymore if no data is received from the connection. The fix is pretty simple, and it should never cause any problem unless the interval duration is very close to zero, which will probably cause strange issues anyway.
Jarema
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an interval is ready, it does not need to register its internal waker, leading to the future not being polled anymore if the connection received no data.
The fix is pretty simple, and it should never cause any problems unless the interval duration is very close to zero, which will probably cause strange issues anyway.