Add source implementation for Error #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of errors do contain source, but the Error type did not actually implement the `source()` method and was always returning `None`, using the default implementation. Thanks @hseeberger and @thomastaylor312 for reporting this indirectly. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
|
Hehe, I had found this peculiarity (not implementing |
|
Any idea when you will release a new version / fix including this PR? |
|
We're preparing for the release. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of errors do contain source, but the Error type did not actually implement the
source()method and was always returningNone, using the default implementation. Thanks @hseeberger and @thomastaylor312 for reporting this indirectly.Signed-off-by: Tomasz Pietrek tomasz@nats.io