-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the async_nats crate into the nats crate under the asynk module #192
Conversation
## Breaking Changes | ||
|
||
- #*** the async_nats crate has been merged into the | ||
main nats crate, under the `asynk` module name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can in not be called async?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async is a reserved keyword in Rust, and this is also the name we used in the past when the async functionality was in the same crate
@@ -4,6 +4,10 @@ | |||
|
|||
- #192 the async_nats crate has been merged into the | |||
main nats crate, under the `asynk` module name. | |||
- #192 the `jetstream::IntervalTree` type has been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are leaning towards calling it OrderedConsumer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be done the Go client version this week, got delayed on server stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review! |
The async_nats crate was merged into the standard nats crate as a module and is no longer maintained. nats-io/nats.rs#192 This will unblock jetstream support vectordotdev#10534.
The async_nats crate was merged into the standard nats crate as a module and is no longer maintained. nats-io/nats.rs#192 This will unblock jetstream support #10534.
The async_nats crate was merged into the standard nats crate as a module and is no longer maintained. nats-io/nats.rs#192 This will unblock jetstream support #10534.
No description provided.