Merge the async_nats crate into the nats crate under the asynk module #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Breaking Changes | ||
|
|
||
| - #*** the async_nats crate has been merged into the | ||
| main nats crate, under the `asynk` module name. |
There was a problem hiding this comment.
Can in not be called async?
There was a problem hiding this comment.
async is a reserved keyword in Rust, and this is also the name we used in the past when the async functionality was in the same crate
| @@ -4,6 +4,10 @@ | |||
|
|
|||
| - #192 the async_nats crate has been merged into the | |||
| main nats crate, under the `asynk` module name. | |||
| - #192 the `jetstream::IntervalTree` type has been made | |||
There was a problem hiding this comment.
I think we are leaning towards calling it OrderedConsumer.
There was a problem hiding this comment.
Should be done the Go client version this week, got delayed on server stuff.
|
Thanks for the review! |
aditsachde
added a commit
to aditsachde/vector
that referenced
this pull request
Feb 23, 2022
The async_nats crate was merged into the standard nats crate as a module and is no longer maintained. nats-io/nats.rs#192 This will unblock jetstream support vectordotdev#10534.
spencergilbert
pushed a commit
to vectordotdev/vector
that referenced
this pull request
Feb 24, 2022
The async_nats crate was merged into the standard nats crate as a module and is no longer maintained. nats-io/nats.rs#192 This will unblock jetstream support #10534.
tobz
pushed a commit
to vectordotdev/vector
that referenced
this pull request
Feb 25, 2022
The async_nats crate was merged into the standard nats crate as a module and is no longer maintained. nats-io/nats.rs#192 This will unblock jetstream support #10534.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.