Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Context::get_consumer_from_stream #502

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Add Context::get_consumer_from_stream #502

merged 1 commit into from
Apr 28, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jun 15, 2022

Derek asked about a direct method to avoid one additional call to the server.
Useful mostly when you get very few Consumers and latency is critical.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema requested a review from caspervonb June 15, 2022 10:01
caspervonb
caspervonb requested changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API is already fluid, is this really measurable? If so, these could live in a ConsumerExt trait or something along those lines.

Lets discuss this more on our next sync call (likely pushing this to the next release).

@Jarema
Copy link
Member Author

Jarema commented Jun 16, 2022

Agree, this should be an ConsumerExt

@Jarema
Copy link
Member Author

Jarema commented Dec 27, 2022

After recent changes, all clients will implement this and it should be available without Ext.

@Jarema Jarema force-pushed the jarema/add-direct-consumer-method branch 2 times, most recently from e2a2e47 to bb97156 Compare February 3, 2023 08:14
caspervonb
caspervonb approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema
Add Context::get_consumer_from_stream
7c3360e 
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema force-pushed the jarema/add-direct-consumer-method branch from bb97156 to 7c3360e Compare April 28, 2023 12:12
@Jarema Jarema merged commit 8af5803 into main Apr 28, 2023
@Jarema Jarema deleted the jarema/add-direct-consumer-method branch April 28, 2023 22:04
@Jarema Jarema mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarema @caspervonb