Multiple endpoints service #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema/multiple-endpoint-svc
branch
from
ba99224
to
627c54b
Compare
caspervonb
reviewed
Jan 5, 2023
| stats: Arc<Mutex<Stats>>, | ||
| client: Client, | ||
| endpoint: String, | ||
| shutdown: Pin<Box<dyn Future<Output = Result<(), tokio::sync::broadcast::error::RecvError>>>>, |
There was a problem hiding this comment.
Why not take the broadcast receiver here? avoid the pin box indirection.
Suggested change
| shutdown: Pin<Box<dyn Future<Output = Result<(), tokio::sync::broadcast::error::RecvError>>>>, | |
| shutdown: Pin<Box<dyn Future<Output = Result<(), tokio::sync::broadcast::error::RecvError>>>>, |
There was a problem hiding this comment.
We would need to either call recv() and store the future in the same way, or call sync try_recv() which would not poll any future, hence when shutdown happens, iterators without messages would not be closed.
Jarema
force-pushed
the
jarema/multiple-endpoint-svc
branch
from
0b09dbe
to
4609fe1
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema/multiple-endpoint-svc
branch
from
6d86992
to
86aea2e
Compare
caspervonb
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek tomasz@nats.io