Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NAK and backoff support #839

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Add NAK and backoff support #839

merged 2 commits into from
Feb 24, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Feb 20, 2023

Resolves #811

@Jarema Jarema force-pushed the jarema/add-nak-to-async branch 4 times, most recently from 4851474 to 8edab33 Compare February 22, 2023 21:46
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bikeshedding about AckKind naming

async-nats/src/jetstream/message.rs Outdated Show resolved Hide resolved
@Jarema Jarema force-pushed the jarema/add-nak-to-async branch 2 times, most recently from 7807f74 to 8989bc5 Compare February 24, 2023 21:40
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 0091c93 into main Feb 24, 2023
@Jarema Jarema deleted the jarema/add-nak-to-async branch February 24, 2023 23:04
@Jarema Jarema mentioned this pull request Mar 1, 2023
@Jarema Jarema mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Support Consumer Retry Backoff and Nak delays
2 participants