Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies #872

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Cleanup dependencies #872

merged 6 commits into from
Mar 14, 2023

Commits on Mar 12, 2023

  1. Drop unused itertools dependency

    @paolobarbolini
    paolobarbolini committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    d97d317 View commit details
    Browse the repository at this point in the history

  2. Reduce tokio features 

    The tokio `full` feature should never get enabled by a library
as it forces downstream users to live with some useless
features enabled, plus the extra dependencies.
    @paolobarbolini
    paolobarbolini committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    e999622 View commit details
    Browse the repository at this point in the history

  3. Remove redundant dependency import 

    tokio-retry was already part of the normal dependencies, so
unless extra features needed to be enabled the import is useless.
    @paolobarbolini
    paolobarbolini committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    90c310e View commit details
    Browse the repository at this point in the history

  4. Import the futures crate without the executor feature

    @paolobarbolini
    paolobarbolini committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    2ce34ef View commit details
    Browse the repository at this point in the history

  5. Replace the subslice crate with the more mature memchr crate

    @paolobarbolini
    paolobarbolini committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    e69bf3a View commit details
    Browse the repository at this point in the history

  6. Replace remaining uses of lazy_static with once_cell 

    once_cell is the correct way forward, as an API similar to it
is also some day going to be stabilized in the Rust std.

As some regexes were already using once_cell, this migrates
the remaining ones.
    @paolobarbolini
    paolobarbolini committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    4880f12 View commit details
    Browse the repository at this point in the history