Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add watch_with_history to KV store #902

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Add watch_with_history to KV store #902

merged 2 commits into from
Apr 1, 2023

Conversation

n1ghtmare
Copy link
Collaborator

Addresses #879

Jarema
Jarema requested changes Mar 28, 2023
View reviewed changes
async-nats/src/jetstream/kv/mod.rs Outdated Show resolved Hide resolved
@n1ghtmare n1ghtmare changed the title Add watch_by_deliver_policy to KV store Add watch_with_history to KV store Mar 30, 2023
@n1ghtmare n1ghtmare requested a review from Jarema March 30, 2023 18:37
Jarema
Jarema approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n1ghtmare @Jarema
Update async-nats/src/jetstream/kv/mod.rs
73945c8 
Co-authored-by: Tomasz Pietrek <melgaer@gmail.com>
@Jarema Jarema merged commit d5e5f63 into nats-io:main Apr 1, 2023
@Jarema Jarema mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb left review comments

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n1ghtmare @caspervonb @Jarema