Remove redundant serde Serialize, Deserialize and default attributes
#929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is in reference to #898? |
Yeah, I was going through all the fields, testing and comparing with the NATS Go client. I couldn't find fields that didn't need |
Jarema
requested changes
Apr 24, 2023
n1ghtmare
force-pushed
the
n1ghtmare/serde-default
branch
from
727405f
to
33b9c0b
Compare
n1ghtmare
changed the title
Serialize and default attributes
caspervonb
requested changes
May 1, 2023
n1ghtmare
force-pushed
the
n1ghtmare/serde-default
branch
from
33b9c0b
to
3c25bd5
Compare
n1ghtmare
changed the title
Serialize and default attributesSerialize, Deserialize and default attributes
|
@caspervonb Thanks, great catch. Indeed I found a few more and I've updated them accordingly. It's possible that I missed some, but most should be taken care of. |
caspervonb
approved these changes
May 8, 2023
n1ghtmare
force-pushed
the
n1ghtmare/serde-default
branch
2 times, most recently
from
e9333b7
to
db39f9c
Compare
|
@n1ghtmare But please shorten the commit message. If you want to put more info in, do that in body. |
n1ghtmare
force-pushed
the
n1ghtmare/serde-default
branch
from
db39f9c
to
68e9c5d
Compare
|
@Jarema Thank you so much. I've shortened the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should match the NATS go client.