Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make client module public #968

Merged
merged 1 commit into from
May 12, 2023
Merged

Make client module public #968

merged 1 commit into from
May 12, 2023

Conversation

caspervonb
Copy link
Collaborator

Closes #966

@caspervonb caspervonb requested a review from Jarema May 12, 2023 08:37
n1ghtmare
n1ghtmare approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@n1ghtmare n1ghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Jarema
Jarema approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit b248fb5 into nats-io:main May 12, 2023
@Jarema Jarema mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ghtmare n1ghtmare n1ghtmare approved these changes

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FlushError or SubscribeError is not publicly available
3 participants
@caspervonb @n1ghtmare @Jarema