Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JetStream KV documentation #991

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

n1ghtmare
Copy link
Collaborator

Added module level description and a missing doc for get. Also some miscellaneous.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs.

There are however some changes requested.

async-nats/src/jetstream/kv/mod.rs Outdated Show resolved Hide resolved
async-nats/src/jetstream/kv/mod.rs Outdated Show resolved Hide resolved
async-nats/src/jetstream/kv/mod.rs Outdated Show resolved Hide resolved
async-nats/src/jetstream/kv/mod.rs Outdated Show resolved Hide resolved
async-nats/src/jetstream/kv/mod.rs Outdated Show resolved Hide resolved
async-nats/src/jetstream/kv/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 8bb4acc into nats-io:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants