Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling chunks in parser #17

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Fix handling chunks in parser #17

merged 3 commits into from
Jan 8, 2024

Conversation

piotrpio
Copy link
Contributor

@piotrpio piotrpio commented Jan 8, 2024

No description provided.

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from Jarema January 8, 2024 00:22
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!
One cleanup comment.

@@ -117,6 +117,7 @@ public class Subscription: AsyncIteratorProtocol {
public func next() async -> Element? {
let msg: NatsMessage? = lock.withLock {
if closed {
print("closed")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the print.

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 93df6a5 into main Jan 8, 2024
1 check passed
@piotrpio piotrpio deleted the fix-parser branch January 8, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants