Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NKEY auth options #65

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Add NKEY auth options #65

merged 9 commits into from
Apr 16, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Apr 15, 2024

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions

Sources/Nats/NatsConnection.swift Show resolved Hide resolved
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema marked this pull request as ready for review April 16, 2024 09:37
@Jarema Jarema requested a review from piotrpio April 16, 2024 09:37
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit 505d8a4 into main Apr 16, 2024
3 checks passed
@Jarema Jarema deleted the add-nkeys-auth branch April 16, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants