Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing public access modifiers #74

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

piotrpio
Copy link
Contributor

@piotrpio piotrpio commented May 15, 2024

Added public access modifiers in several places:

  • JetStream structs (StreamConfig, StreamInfo etc.)
  • JetStream context methods (wait() and request()). I am not sure if request() should be public though, so that needs to be discussed.
  • logger - we should think of a better approach to logger configuration instead of global public var, but that can be done as a separate issue
  • several Error structs

Signed-off-by: Piotr Piotrowski piotr@synadia.com

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested review from Jarema and mtmk May 15, 2024 11:39
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 9d0a36a into main May 15, 2024
3 checks passed
@piotrpio piotrpio deleted the remove-testable-imports branch May 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants