Remove SubscriptionCloseRequest protocol #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to PR #115 and server side [PR](nats-io/nats-streaming-server#203) Noticed that we could have used UnsubscribeRequest since content of that one and SubscriptionCloseRequest were same. Also, the server was actually implemented with UnsubscribeRequest and works fine. What matters is the subject the protocol is sent to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to PR #115 and server side PR 203.
I noticed that we could have used
UnsubscribeRequestsince contentof that one and
SubscriptionCloseRequestwere same for relevant fields.Also, the server was actually implemented with
UnsubscribeRequestand works fine. What matters is the subject the protocol is sent to.