[FIXED] Possible duplicate processing of a PubAck #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that the client timeout at the same time that it receives the pubAck from the server. It is acceptable to have the client report a failure because it timed-out, even though the ack has just been received, but it is not correct to invoke the AckHandler twice for the same guid. Also, the issue would cause serious problems for synchronous Publish() calls. See issue report for details. Resolves #130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the client timeout at the same time that it
receives the pubAck from the server. It is acceptable to have
the client report a failure because it timed-out, even though
the ack has just been received, but it is not correct to invoke
the AckHandler twice for the same guid.
Also, the issue would cause serious problems for synchronous
Publish() calls. See issue report for details.
Resolves #130