Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the "go get" instruction to avoid error report [ci skip] #261

Merged
merged 1 commit into from
May 16, 2019

Conversation

kozlovic
Copy link
Member

Doing "go get github.com/nats-io/stan.go" reports an error about
"no such file or directory" although things are downloaded ok.

However, doing "go get github.com/nats-io/stan.go/" (with the
trailing "/") works fine.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Doing "go get github.com/nats-io/stan.go" reports an error about
"no such file or directory" although things are downloaded ok.

However, doing "go get github.com/nats-io/stan.go/" (with the
trailing "/") works fine.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from wallyqs May 16, 2019 15:01
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed locally this works

@kozlovic kozlovic merged commit 6830b01 into master May 16, 2019
@kozlovic kozlovic deleted the fix_go_get branch May 16, 2019 15:27
@vtolstov
Copy link

Why you dont want, nats-go like other projects do?

@kozlovic
Copy link
Member Author

@vtolstov It was not my decision. But some other projects also use the .<lang> for repo names. This is one of such project: https://github.com/miscreant

@vtolstov
Copy link

@kozlovic thanks!

@tpoxa
Copy link

tpoxa commented Aug 12, 2019

go version
go version go1.11.4 darwin/amd64
 go get github.com/nats-io/stan.go/
stat github.com/nats-io/stan.go: no such file or directory

@kozlovic
Copy link
Member Author

@tpoxa This is an issue with go tooling. Check this: #256 (comment)

We have filed an issue with the Go team: golang/go#32483

@wallyqs
Copy link
Member

wallyqs commented Aug 12, 2019

@tpoxa when using Go modules you could too specify the branch or tag and it would work

go get github.com/nats-io/stan.go/@latest
go get github.com/nats-io/stan.go/@v0.5.0

@tpoxa
Copy link

tpoxa commented Aug 12, 2019

@wallyqs it works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants