Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate default config for each request. #264

Merged
merged 1 commit into from
May 23, 2019
Merged

Conversation

anxinyf
Copy link
Contributor

@anxinyf anxinyf commented May 22, 2019

DEPRECATED: Use GetDefaultOptions() instead.
DefaultOptions is not safe for use by multiple clients.
For details see nats-io/nats.go#308.
DefaultOptions are the NATS Streaming client's default options

Signed-off-by: anxinyf anxinyf@gmail.com

DEPRECATED: Use GetDefaultOptions() instead.
DefaultOptions is not safe for use by multiple clients.
For details see nats-io/nats.go#308.
DefaultOptions are the NATS Streaming client's default options

Signed-off-by: anxinyf <anxinyf@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 93.886% when pulling a38114b on anxinyf:master into 71833a7 on nats-io:master.

@MartinForReal
Copy link
Contributor

@kozlovic Could you please help review this pr? @anxinyf kindly helped split commit in #263. Thank you both of you!

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 62790d7 into nats-io:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants