Update deps and make use of -modfile for tests deps #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
approved these changes
Jun 22, 2020
.travis.yml
Outdated
| @@ -17,7 +11,6 @@ before_script: | |||
| - find . -type f -name "*.go" | grep -v "/pb/" | xargs misspell -error -locale US | |||
| - staticcheck ./... | |||
| script: | |||
| - go test -i -v ./... | |||
| - go test -v -race ./... | |||
| - go test -v -race -p=1 ./... -modfile go_tests.mod | |||
There was a problem hiding this comment.
Actually in this repo we don't because there is a single test package. I can remove.
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@derekcollison @wallyqs @philpennock I think that we could merge this PR even though that puts Go 1.14 as the minimal version... for Travis. That is, a user of this lib will have the proper go.mod for deps needed to build the library, regardless of what Go version they are using. |
|
Sounds ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Kozlovic ivan@synadia.com