Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Mirror Editor position in Preview pane. #3484

Merged
merged 57 commits into from
Sep 16, 2024
Merged

Live Mirror Editor position in Preview pane. #3484

merged 57 commits into from
Sep 16, 2024

Commits on May 18, 2024

  1. Add live scrolling to keep the preview in sync with editor position. 

    This catchs CTRL-HOME, CTRL-END, and mouseclicks.

It tests for changes on arrow keys and enter.

Not sure if it's the best way to do this, but it works quickly on a large, crappy brew.
    @dbolacksn
    dbolacksn committed May 18, 2024
    Configuration menu
    Copy the full SHA
    8ece547 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Add a Live Scroll lock/unlock below Brew/Source Jump buttons. 

    The button displays the *next* state of the toggle. IE, if the current state is locked ( Live scrolling is active ) the icon is unlock with a corresponding mouse-over.

It may be desirable to invert this.
    @dbolacksn
    dbolacksn committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b7dc47f View commit details
    Browse the repository at this point in the history

  2. Update Jump keys to match parent PR and shift live scrolling to scrol… 

    …l-lock.

Needs non-PC testing.
    @dbolacksn
    dbolacksn committed May 19, 2024
    Configuration menu
    Copy the full SHA
    86887b5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed May 19, 2024
    Configuration menu
    Copy the full SHA
    07f2e8b View commit details
    Browse the repository at this point in the history

  4. Add a CR.

    @dbolacksn
    dbolacksn committed May 19, 2024
    Configuration menu
    Copy the full SHA
    bacdd65 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. WIP

    @dbolacksn
    dbolacksn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    835ca0d View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed May 21, 2024
    Configuration menu
    Copy the full SHA
    77450ed View commit details
    Browse the repository at this point in the history

  2. Constant a lookup.

    @dbolacksn
    dbolacksn committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e69132b View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Store livescrolling in local storage 

    Small fixes for loading the correct current state.
    @dbolacksn
    dbolacksn committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a715c9e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    cca79d4 View commit details
    Browse the repository at this point in the history

  3. Add additional visual hinting to liveScroll lock.

    @dbolacksn
    dbolacksn committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4818f70 View commit details
    Browse the repository at this point in the history

  4. Missed a couple of variable repalcements.

    @dbolacksn
    dbolacksn committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ea9f9a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Resolve timing issue with liveScroll on linking. 

    Checks to see if prevProps.livescroll has a proper Bool value. If not, do not brewJump() in editor.componantSDidUpdate.
    @dbolacksn
    dbolacksn committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    510d8f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7e3f2a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    19ee3d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1844626 View commit details
    Browse the repository at this point in the history

  2. Remove Livescrolling toggle hot-key.

    @dbolacksn
    dbolacksn committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dcdc8b4 View commit details
    Browse the repository at this point in the history

  3. Move livescrollToggle function out into a class method instead of an … 

    …anonymous function.

Adjust code accordingly ( event.target vs document.getElementByClassname )
    @dbolacksn
    dbolacksn committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b340276 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f10ef2b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0057e2b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2d781f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    17b22b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    78c4061 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fa63f1d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5431d3e View commit details
    Browse the repository at this point in the history

  2. Fix merge

    @dbolacksn
    dbolacksn committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6952933 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Bind livescrolling when done via scrollbars.

    @dbolacksn
    dbolacksn committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e27e61a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    f24e477 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a4f30d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Merge branch 'master' into Issue_241_Part_II 

    Clean up a small bit of linting in the pr related functions.
    @dbolacksn
    dbolacksn committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    82f2d02 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Merge branch 'master' into Issue_241_Part_II

    @calculuschild
    calculuschild authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    b124e55 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Bodge Render side mirroring back into place.

    @dbolacksn
    dbolacksn committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    7a37bf4 View commit details
    Browse the repository at this point in the history

  2. Update tooltips for locking.

    @dbolacksn
    dbolacksn committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fa74fb4 View commit details
    Browse the repository at this point in the history

  3. Fix "clicked on the toggle ring" crash with scroll lock. 

    The code was doing dom-climbing math based on clicking on the div contents but was attached to the div. Moved the onClick to the contents.
    @dbolacksn
    dbolacksn committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1e9c742 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch 'master' into pr/3484

    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    707b90e View commit details
    Browse the repository at this point in the history

  2. Move onClick from the lock icon to the whole button

    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    51c8973 View commit details
    Browse the repository at this point in the history

  3. Set button appearance based on state 

    Avoid manually editing the DOM elements. Let the Render function update the appearance based on state.
    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0fbb487 View commit details
    Browse the repository at this point in the history

  4. Remove setting button styles in componentDidMount 

    Just set the state, and the renderer will know what to display.
    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3152964 View commit details
    Browse the repository at this point in the history

  5. remove unused variable

    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b5155ed View commit details
    Browse the repository at this point in the history

  6. Simplify scroll event for source editor using lodash Throttle

    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ec74b99 View commit details
    Browse the repository at this point in the history

  7. Jump based on scroll position, not cursor position

    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    45a9501 View commit details
    Browse the repository at this point in the history

  8. Better line position (viewport has some margin)

    @calculuschild
    calculuschild committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e5ab223 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8fa5eeb View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Add Pagella face to Blank Template. 

    Pagella is a TeX update of the URW Palladio L face that is a good substitute for the commonly used Book Antiqua and Palatino faces.

https://en.wikipedia.org/wiki/Palatino#:~:text=The%20first%20legal%20free%20version,on%20URW%20Palladio%20L%20font.
    @dbolacksn
    dbolacksn committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7d29856 View commit details
    Browse the repository at this point in the history

  2. Revert "Add Pagella face to Blank Template." 

    This reverts commit 7d29856.
    @dbolacksn
    dbolacksn committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    84d237e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Add check for scroll event complete/ lift page state up

    @calculuschild
    calculuschild committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3ef91cb View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Merge branch 'master' into pr/3484

    @calculuschild
    calculuschild committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d4fa5d5 View commit details
    Browse the repository at this point in the history

  2. Update editor.jsx

    @calculuschild
    calculuschild committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    181c6bf View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Put page jump checks in componentDidUpdate 

    Jump when the current page for brew or editor changes
    @calculuschild
    calculuschild committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    84c0242 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:naturalcrit/homebrewery

    @dbolacksn
    dbolacksn committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    dbe56ab View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into Issue_241_Part_II

    @dbolacksn
    dbolacksn committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    3388fcc View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Fix BrewRenderer scrolling to 0

    @calculuschild
    calculuschild committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    85401ba View commit details
    Browse the repository at this point in the history

  2. Clean up unused code

    @calculuschild
    calculuschild committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    81ab941 View commit details
    Browse the repository at this point in the history

  3. Remove unused variable

    @calculuschild
    calculuschild committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c07c02f View commit details
    Browse the repository at this point in the history

  4. More cleanup

    @calculuschild
    calculuschild committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a353425 View commit details
    Browse the repository at this point in the history

  5. Remove console logs

    @calculuschild
    calculuschild committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    25a40e3 View commit details
    Browse the repository at this point in the history

  6. More logic simplification

    @calculuschild
    calculuschild committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    48bdc41 View commit details
    Browse the repository at this point in the history