Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Ink Friendly snippet making text unselectable in output PDF #3564

Merged

Conversation

G-Ambatte
Copy link
Collaborator

This PR resolves #3563.

This PR changes the Ink Friendly snippet to use box-shadow instead of filter. This should achieve the same visual effect while not rendering the output PDF as an image.

@G-Ambatte G-Ambatte self-assigned this Jul 8, 2024
@G-Ambatte G-Ambatte added P2 - minor feature or not urgent Minor bugs or less-popular features 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Jul 8, 2024
@dbolack-ab
Copy link
Collaborator

Is there a Brew we can compare before and after results with?

@G-Ambatte
Copy link
Collaborator Author

Is there a Brew we can compare before and after results with?

Example 1: Current
HB link: https://homebrewery.naturalcrit.com/share/wjdLwCIMiGf7
PDF: Ink Friendly Example 1_ Current - The Homebrewery.pdf

Example 2: PR Changes
HB link: https://homebrewery.naturalcrit.com/share/oU5XmiPzlhMg
PDF: Ink Friendly Example 2_ Proposed - The Homebrewery.pdf

You should see that the "current" brew contains only a single framed monster block and the Ink Friendly snippet. However, the PDF output is that of an image; the text is not able to be selected or interacted with.
However, you should also see that the PR changes contains the exact same framed monster block, and the only difference is in the style, where the Ink Friendly snippet has been replaced with the version from this PR. The resultant PDF has text that can be highlighted and interacted with as expected for text.

@calculuschild calculuschild merged commit c2678e5 into naturalcrit:master Aug 1, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 - minor feature or not urgent Minor bugs or less-popular features 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ink Friendly snippet causes PDF text to be unselectable
3 participants