cave query: add livelive, fix live query #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jefferis
commented
Aug 14, 2024
jefferis
commented
- implements time travel of livelive annotations back to older segmentation versions
- also includes two important bug fixes in flywire_rootid
jefferis
force-pushed
the
feature/live-query
branch
from
bc4e7ff
to
d84efac
Compare
* apparently versions were coming out of cave as numeric
* live is on by default if we have not specified a version * live can specify a timestamp other than now * store now timestamp just once so it's consistent if we have to read from multiple offsets
* it seems the timestamp was not previously being correctly processed anyway
* revealed by test for timetravel option * if passed a version there was an error because flywire_timestamp doesn't like getting both version and timestamp
* now includes test
* thinko from previous large scale changes * if we specify a version but it has expired, we need to use live mode to fetch it with a timestamp.
* simplify dict handling via cavedict_rtopy
jefferis
force-pushed
the
feature/live-query
branch
from
826b0f1
to
a5cff2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 57.34% 58.32% +0.97%
==========================================
Files 38 38
Lines 5111 5190 +79
==========================================
+ Hits 2931 3027 +96
+ Misses 2180 2163 -17 ☔ View full report in Codecov by Sentry. |
* would hav been helpful for Nam
* as well as timestamp * with test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.