Feature/cache flywire leaves #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* so that we can be sure it doesn't change when we refactor
* includes brotli which is most performant but perhaps not completely standard as an option
* in fact the higher level function will choose brotli if available
* these could result in duplicates in the cache * also fix bug in handling more than 1 rootid * with tests
* and remove matrixStats dependency * uses max.cols (which I had not spotted before) and pmax
* not a massive effect, but still 580->412 ms for my test query
> bench::mark(current=flywire_ntpred("720575940615237849"), min_time = 5)
# A tibble: 1 x 13
expression min median `itr/sec` mem_alloc `gc/sec` n_itr n_gc total_time result memory time gc
<bch:expr> <bch:> <bch:t> <dbl> <bch:byt> <dbl> <int> <dbl> <bch:tm> <list> <list> <lis> <lis>
1 current 557ms 586ms 1.22 16.2MB 0.486 5 2 4.11s <ntpre… <Rprof… <bch… <tib…
> bench::mark(p3 <- flywire_ntpred("720575940615237849"))
# A tibble: 1 x 13
expression min median `itr/sec` mem_alloc `gc/sec` n_itr n_gc
<bch:expr> <bch> <bch:> <dbl> <bch:byt> <dbl> <int> <dbl>
1 p3 <- flywire_ntpred("720575940615237849") 412ms 412ms 2.43 16.7MB 2.43 1 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation of #67