You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but this has a logic error where point indexes and identifiers are mixed. For example in the example below prune is filled with the contents of the PointNo column (i.e. identifiers in line 211) but then used to subscript the PointNo column in line 239
This means that the example for hemibrain_clean_skeleton skeleton fails. This is a good example of code that should have a test (not necessarily with all the neurons in the example).
hemibrain_clean_skeleton
callsprune_synapseless_branches
https://github.com/flyconnectome/hemibrainr/blob/36f255878d9c8cbf256ad8b1c8f0dd746d384a8c/R/hemibrain_read_neurons.R#L183-L184
but this has a logic error where point indexes and identifiers are mixed. For example in the example below prune is filled with the contents of the
PointNo
column (i.e. identifiers in line 211) but then used to subscript the PointNo column in line 239https://github.com/flyconnectome/hemibrainr/blob/36f255878d9c8cbf256ad8b1c8f0dd746d384a8c/R/hemibrain_read_neurons.R#L211-L241
In the example below this results in prune_synapseless_branches returning c(NA,NA,NA) for the axonic cable.
The text was updated successfully, but these errors were encountered: