-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow centrality #45
Flow centrality #45
Conversation
alexanderbates
commented
Jan 27, 2020
- Not currently available in the natverse (only clunky catnat)
- Could also go in catmaid package
- Needs synapses, might not be appropriate for nat
- A little slow, needs speeeding up
* Not currently available in the natverse (only clunky catnat) * Could also go in catmaid package * Needs synapses, might not be appropriate for nat * A little slow, needs speeeding up
@romainFr do you have any comments on this?
…Sent from my iPhone
On 27 Jan 2020, at 22:37, Alexander Bates ***@***.***> wrote:
@alexanderbates requested your review on: #45 Flow centrality.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I haven't thought much about flow centrality, but it does sound like it could be a nice feature to add. I'd need to get a bit more familiar with |
nodes[, c("post","pre","up.syns.in","up.syns.out","flow.cent")] = 0 | ||
nodes[,"Label"] = 3 | ||
nodes = nodes[unlist(c(root, lapply(segs, function(x) x[-1]))),] | ||
syns.in = x$connectors[x$connectors$prepost == 1, ][, "treenode_id"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general connectors(x)
is preferred to x$connectors
since some day the details of how we store synapse information could change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could import from rcatmaid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the question is whether or not we want this package to just deal with sending cyphers and making other API queries, or whether we want bits of code that help analysis of data retrieved from neuPrint. In general we do not perhaps, but things like flow_centrality
are fairly specifically useful for neuprint/catmaid neurons.
Hmm, I have a feeling that there are certain neuron features first implemented in catmaid that really ought to be added to nat at this point. This includes generic handling of
You are right @alexanderbates that I hadn't thought through re In fact this would probably allow us to avoid writing such methods in a number of cases. Take
I think if we defined a
In fact we could do even better and eliminate the second call to xform by rbinding the node and connector locations together. |
@jefferis we should make synapses a feature of nat. In the meantime, the contents of this branch has been moved to a new package specifically for hemibrain data analysis: https://github.com/flyconnectome/hemibrainr |