Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read.neurons.catmaid could include annotation info #18

Closed
jefferis opened this issue Apr 27, 2015 · 6 comments
Closed

read.neurons.catmaid could include annotation info #18

jefferis opened this issue Apr 27, 2015 · 6 comments

Comments

@jefferis
Copy link
Collaborator

For example if there were multiple matching annotations, each neuron could be tagged with the (first) matching annotation.

@jefferis
Copy link
Collaborator Author

Or the neuronlist could have the annotations as an attribute. The minimum is that there should be an example showing how to use this.

@jefferis
Copy link
Collaborator Author

see catmaid_get_annotations_for_skeletons and #38

@jefferis
Copy link
Collaborator Author

Question is where to put this. Probably best to add as list of annotations as a column to main data.frame. Could separately add catmaid_get_annotations_for_skeletons data.frame as another attribute. But might need to add a helper function to look for tag. neuron_tag? Perhaps also a point_tag could be another addition?

jefferis added a commit that referenced this issue Jan 15, 2016
* implements #18
* but does not yet provide an easy way to test
@jefferis
Copy link
Collaborator Author

putting the annotations in a column of the data.frame then causes problems when you try use

nl[,]

or

write.csv(as.data.frame(nl))

So I am thinking that maybe the approach of providing a helper function might work best.

@jefferis jefferis reopened this Feb 14, 2016
@jefferis
Copy link
Collaborator Author

I think the tags info should probably not be directly in the data.frame so edb516f needs to be rolled back.

@jefferis
Copy link
Collaborator Author

Eventually opted to include this as a separate data.frame since that seemed the most lightweight approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant