-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: don't auto delete component queue #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test failures look unrelated (the failures are from parts of the code i did not change) i don't think the linting job has ever passed |
herrmt
approved these changes
Jun 23, 2023
well it passes locally on python 3.9.16 lol
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #107 i fixed a typo and set component queues to auto delete
but after using that a bit, i have changed my mind; reasoning below
firstly, according to the documentation, if so configured, these queues will be deleted when the consumer disconnects... i could not find anything on the internet that says the queue has to be empty... so it deletes the queue even if it's not empty, as long as the consumer has disconnected
also it's difficult to update an existing component to ergo 0.11.3 because:
on the other hand, if this pr is approved, going to 0.11.4 will be easy because 0.11.3 queues will be auto deleted when the component shuts down for deploy, so there will be no problem recreating them without auto delete
instance queues remain auto delete, which i think is correct:
ergo/ergo/amqp_invoker.py
Line 68 in 3464426