Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inf-34] add docs, mv module, lint tests #53

Merged
merged 6 commits into from
Jan 3, 2022
Merged

Conversation

zekenautilus
Copy link
Contributor

@zekenautilus zekenautilus commented Jan 3, 2022

Description

  • added docs! currently built locally, but signed up for readthedocs and should be able to host there!
  • some initial linting ci tests to verify code style is enforced pre merge
  • renamed module from src to ergo

Visuals

Screen.Recording.2022-01-03.at.9.05.00.AM.mov

name: "Enforce PEP8"
command: |
. venv/bin/activate
autopep8 --aggressive --aggressive --recursive ./ergo --diff --exit-code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aggressive twice?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just means be extra aggressive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i legit thought it was a typo, but this is the intended usage:

image

Copy link
Contributor

@ahuman-bean ahuman-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #53 (46e263a) into master (81a3151) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   64.00%   64.00%           
=======================================
  Files          19       19           
  Lines         725      725           
=======================================
  Hits          464      464           
  Misses        261      261           
Impacted Files Coverage Δ
ergo/key.py 100.00% <ø> (ø)
ergo/schematic.py 20.89% <ø> (ø)
ergo/types.py 100.00% <ø> (ø)
ergo/util.py 97.77% <ø> (ø)
ergo/amqp_invoker.py 29.26% <100.00%> (ø)
ergo/config.py 58.00% <100.00%> (ø)
ergo/ergo_cli.py 36.61% <100.00%> (ø)
ergo/flask_http_invoker.py 47.36% <100.00%> (ø)
ergo/function_invocable.py 37.09% <100.00%> (ø)
ergo/http_invoker.py 65.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a3151...46e263a. Read the comment docs.

@zekenautilus zekenautilus changed the title add docs, mv module, lint tests [inf-34] add docs, mv module, lint tests Jan 3, 2022
@zekenautilus zekenautilus merged commit bc6e3a1 into master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants