replace signal.raise_signal with os.kill #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachschubert
force-pushed
the
schubert/restore-python3.7-compatibility
branch
from
ebbb0dc
to
b2b6a21
Compare
zachschubert
commented
Aug 9, 2022
| @@ -151,4 +152,4 @@ def _shutdown(self, signum, *_): | |||
| self._component_queue.queue_unbind() | |||
| self._connection.close() | |||
| signal.signal(signum, 0) | |||
| signal.raise_signal(signum) | |||
There was a problem hiding this comment.
signal.raise_signal was added in python 3.8
zachschubert
force-pushed
the
schubert/restore-python3.7-compatibility
branch
2 times, most recently
from
5361996
to
a1f04ce
Compare
zachschubert
force-pushed
the
schubert/restore-python3.7-compatibility
branch
from
a1f04ce
to
c8fd2d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 68.37% 68.39% +0.02%
==========================================
Files 33 33
Lines 1467 1468 +1
==========================================
+ Hits 1003 1004 +1
Misses 464 464
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.