Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.4] Job Re-run Doesn't Honor has_sensitive_variables Flag on Job #2184

Closed
bryanculver opened this issue Aug 11, 2022 · 0 comments · Fixed by #2196
Closed

[1.4] Job Re-run Doesn't Honor has_sensitive_variables Flag on Job #2184

bryanculver opened this issue Aug 11, 2022 · 0 comments · Fixed by #2196
Assignees
@briddo
Labels
type: bug Something isn't working as expected
Milestone
v1.4.0

Comments

@bryanculver
Copy link
Member

bryanculver commented Aug 11, 2022 •
edited
Loading

Environment

  • Python version: 3.8
  • Nautobot version: 1.4.0rc1

Steps to Reproduce

  1. Run job marked has_sensitive_variables
  2. Visit Job Results

Expected Behavior

Previous job run in not re-runnable, kwargs are not stored in database. Job results would only expect to honor has_sensitive_variables while that Job is marked as such. Changing that value would not restore/remove past runs values.

Observed Behavior

Job run is re-runnable, kwargs are stored in database.

This is due to #1875 coming in before #2091.
@bryanculver bryanculver added the type: bug Something isn't working as expected label Aug 11, 2022
@bryanculver bryanculver added this to the v1.4.0 milestone Aug 11, 2022
@bryanculver bryanculver changed the title [1.4] Job-Rerun Doesn't Honor has_sensitive_variables Flag on Job [1.4] Job Re-run Doesn't Honor has_sensitive_variables Flag on Job Aug 11, 2022
@briddo briddo self-assigned this Aug 11, 2022
bryanculver added a commit that referenced this issue Aug 12, 2022
@bryanculver
Close #2184
911365d 
Close #1845

* Honor `has_sensitive_variables` when storing kwargs for re-run
* Update Job class docstring
* Add test for not storing kwargs on rerun for sensitive variable jobs
* Fix #1845 to suppor testing
* Update job sensitive variables messaging
@bryanculver bryanculver mentioned this issue Aug 12, 2022
Merged
2 tasks
This was referenced Aug 14, 2022
Closed
Closed
bryanculver added a commit that referenced this issue Aug 15, 2022
@bryanculver
Add release-note for #1845, #2029, #2176, #2184, #2190, #2200
bce0a70
briddo pushed a commit that referenced this issue Aug 16, 2022
@bryanculver @briddo
Add release-note for #1845, #2029, #2176, #2184, #2190, #2200
e578cc6
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@briddo briddo

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v1.4.0
2 participants
@bryanculver @briddo