Add tags to location form #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanculver
reviewed
Aug 12, 2022
bryanculver
approved these changes
Aug 13, 2022
bryanculver
added a commit
that referenced
this pull request
Aug 15, 2022
briddo
pushed a commit
that referenced
this pull request
Aug 16, 2022
* Add tags to location form Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #DNS
What's Changed
A keen eyed customer noted that tags was missing from the Location form.
Additional/related fixes added by @glennmatthews:
tagswas correct with how we want to do things moving forward, but there's existing code (notably the implementation ofTagColumn) that expects this filter to be namedtagas it is (incorrectly) named in all other existing filters. So sadly I changed it totag.location_edit.htmlso that tags/custom fields/relationships/notes show up in this form.configcontextschema_edit.html, and that the forms for ConfigContext were missing the Notes mixins.TODO
N/A