Fixes to onboarding Cluster, IPAddress, Prefix, Rack to Dynamic Groups
#2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic Groups
- `DynamicGroup._map_filter_fields` now explicitly skips any method filters. This is a stop-gap until we are able to vet every method filter on every filterset. This is because we moved to Q object filtering for nested groups.
- Introduced a new pattern for filterset method filters to be backed by a corresponding `generate_query_{filter_method}` method that itself emits a `Q` object that can be used by `DynamicGroup.generate_query()` machinery
- Specific filterset fields have been revised to have these `generate_query_` filterset methods defined to maintain feature parity w/ v1.3 Dynamic Groups (in the case of Device/VM), and list view filtering (in the case of Rack, IPAddress, Prefix)
- Fixed a bug in which method filters would only be filtered out if they were found to be a missing field
4 tasks
Comment on lines
+323
to
+324
| # This stringification is done to make the `pretty_print_query()` output look human-readable, | ||
| # and nothing more. It would work as complex objects but looks bad in the web UI. |
There was a problem hiding this comment.
Is this still an issue after #2197?
There was a problem hiding this comment.
Yes:
Compared to your fixes with leaving the stringification in there:
There was a problem hiding this comment.
Cool, thanks. Not blocking but wonder if we can/should fix this in pretty_print_query() itself?
There was a problem hiding this comment.
Yeah I think that is probably better so it's not up to plugin authors or us in the future.
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
* nav fix * include inc/javascript in graphiql.html
|
Thanks Jathan! User experience looks much better now! |
jathanism
commented
Aug 15, 2022
jathanism
commented
Aug 15, 2022
jathanism
commented
Aug 15, 2022
jathanism
commented
Aug 15, 2022
- Parent groups that had null filters were linking to an empty list view - `DynamicGroup.get_group_membership_url()` has been updated to always link to the "Members" tab on the detail view for that group. - `DynamicGroup.members_base_url` has been eliminated.
bryanculver
reviewed
Aug 15, 2022
bryanculver
reviewed
Aug 15, 2022
bryanculver
reviewed
Aug 15, 2022
Co-authored-by: Jathan McCollum <jathan@gmail.com>
|
Note here: We skipped automatic field population on a few of these models due in part to this: #2162 (ex: |
briddo
pushed a commit
that referenced
this pull request
Aug 16, 2022
…ic Groups (#2200) - `DynamicGroup._map_filter_fields` now explicitly skips any method filters. This is a stop-gap until we are able to vet every method filter on every filterset. This is because we moved to Q object filtering for nested groups. - Introduced a new pattern for filterset method filters to be backed by a corresponding `generate_query_{filter_method}` method that itself emits a `Q` object that can be used by `DynamicGroup.generate_query()` machinery - Specific filterset fields have been revised to have these `generate_query_` filterset methods defined to maintain feature parity w/ v1.3 Dynamic Groups (in the case of Device/VM), and list view filtering (in the case of Rack, IPAddress, Prefix) - Fixed a bug in which method filters would only be filtered out if they were found to be a missing field - Parent groups that had null filters were linking to an empty list view - `DynamicGroup.get_group_membership_url()` has been updated to always link to the "Members" tab on the detail view for that group. - `DynamicGroup.members_base_url` has been eliminated. Co-authored-by: Marek Zbroch <marek.zbroch@networktocode.com> Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #2188
What's Changed
DynamicGroup._map_filter_fieldsnow explicitly skips any method filters. This is a stop-gap until we are able to vet every method filter on every filterset. This is because we moved to Q object filtering for nested groups.generate_query_{filter_method}method that itself emits aQobject that can be used byDynamicGroup.generate_query()machinerygenerate_query_filterset methods defined to maintain feature parity w/ v1.3 Dynamic Groups (in the case of Device/VM), and list view filtering (in the case of Rack, IPAddress, Prefix)TODO