Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rich for task output highlighting, print full docker-compose command being run #2176

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Use rich for task output highlighting, print full docker-compose command being run #2176

merged 5 commits into from
Aug 15, 2022

Conversation

glennmatthews
Copy link
Contributor

@glennmatthews glennmatthews commented Aug 10, 2022 •
edited

Closes: #DNE

What's Changed

- Update tasks.py to use the newer docker compose CLI instead of the older docker-compose CLI (please pull down this branch and verify that this change works for you!)

  • Add rich as a development dependency
  • Use rich to add syntax highlighting and styling to invoke task output
  • For docker compose commands called by tasks, print the full command invocation to assist with troubleshooting and reproducibility.

image

@glennmatthews
Change docker-compose to docker compose, use rich for task output hig…
8534f57 
…hlighting, output full docker compose commands from tasks
@glennmatthews glennmatthews added the type: housekeeping Changes to the application which do not directly impact the end user label Aug 10, 2022
bryanculver
bryanculver reviewed Aug 10, 2022
View reviewed changes
tasks.py Outdated Show resolved Hide resolved
@bryanculver bryanculver changed the base branch from next to develop August 10, 2022 18:55
@glennmatthews glennmatthews changed the title Change docker-compose to docker compose, use rich for task output highlighting Use rich for task output highlighting, print full docker-compose command being run Aug 11, 2022
@bryanculver bryanculver mentioned this pull request Aug 13, 2022
Merged
12 tasks
@glennmatthews glennmatthews self-assigned this Aug 15, 2022
jathanism
jathanism approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sexy!

@bryanculver bryanculver merged commit 1097569 into develop Aug 15, 2022
bryanculver added a commit that referenced this pull request Aug 15, 2022
@bryanculver
Add release-note for #1845, #2029, #2176, #2184, #2190, #2200
bce0a70
briddo pushed a commit that referenced this pull request Aug 16, 2022
@glennmatthews @briddo
Use rich for task output highlighting, print full docker-compose comm…
4b10427 
…and being run (#2176)

* Use rich for task output highlighting, output full docker compose commands from tasks
briddo pushed a commit that referenced this pull request Aug 16, 2022
@bryanculver @briddo
Add release-note for #1845, #2029, #2176, #2184, #2190, #2200
e578cc6
@bryanculver bryanculver deleted the gfm-rich-tasks branch August 17, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver left review comments

@whitej6 whitej6 whitej6 left review comments

@jathanism jathanism jathanism approved these changes

Assignees

@glennmatthews glennmatthews

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glennmatthews @bryanculver @jathanism @whitej6