Added clearer error messages for the nRequest amount validation #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxaddict
requested review from
aguycalled,
chasingkirkjufell and
proletesseract
aguycalled
requested changes
Oct 11, 2019
| if (nReqAmount > proposal.GetAvailable(*pcoinsTip, true)) { | ||
| str = "Requested amount %1 is more than avaible coins in the proposal (%2)\n"; | ||
| } | ||
| msgBox.setText(tr(str.c_str()).arg(NavCoinUnits::formatWithUnit(NavCoinUnits::NAV, nReqAmount), NavCoinUnits::formatWithUnit(NavCoinUnits::NAV, proposal.GetAvailable(*pcoinsTip, true)))); |
Member
There was a problem hiding this comment.
tr() should receive a string as an argument so the parser can correctly extract the text iirc.
std::string str = tr("Requested amount must be greater than 0 NAV (Zero)");
if (nReqAmount > proposal.GetAvailable(*pcoinsTip, true)) {
str = tr("Requested amount %1 is more than avaible coins in the proposal (%2)");
}
msgBox.setText(str.arg(NavCoinUnits::formatWithUnit(NavCoinUnits::NAV, nReqAmount), NavCoinUnits::formatWithUnit(NavCoinUnits::NAV, proposal.GetAvailable(*pcoinsTip, true))));
Contributor
Author
There was a problem hiding this comment.
@aguycalled you mean the tr() call needs to have the string passed inline? and not via variable?
Contributor
Author
There was a problem hiding this comment.
Like this:
QString str = tr("Requested amount must be greater than 0 NAV (Zero)\n");
if (nReqAmount > proposal.GetAvailable(*pcoinsTip, true)) {
str = tr("Requested amount %1 is more than avaible coins in the proposal (%2)\n")
.arg(
NavCoinUnits::formatWithUnit(NavCoinUnits::NAV, nReqAmount),
NavCoinUnits::formatWithUnit(NavCoinUnits::NAV, proposal.GetAvailable(*pcoinsTip, true))
);
}
msgBox.setText(str);
mxaddict
force-pushed
the
clearer-payment-request-errors
branch
from
41c5257 to
9d35495
Compare
…st-errors Conflicts: src/qt/communityfundcreatepaymentrequestdialog.cpp
Contributor
Author
|
Fixed merge conflict |
chasingkirkjufell
approved these changes
Oct 24, 2019
Contributor
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
There was a problem hiding this comment.
tested locally and worked as expected on 18.10
Contributor
Author
|
Lets merge this after 4.7.1 release |
aguycalled
approved these changes
Nov 1, 2019
Contributor
|
str = "Requested amount %1 is more than avaible coins in the proposal (%2)\n"; |
Contributor
|
good catch but isn't it actually "available" ? |
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Dec 5, 2019
…oin#609) * Added clearer error messages for the nRequest amount validation * Added fix for tr calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.