Updates to make the wallet.py and stakeimmaturebalance.py test more reliable#624
Merged
Merged
Conversation
mxaddict
requested review from
aguycalled,
chasingkirkjufell and
proletesseract
Member
|
utACK |
Member
|
wallet.py test still fails |
mxaddict
force-pushed
the
update-wallet-rpc-test
branch
from
f62b8c1 to
a3a0c9d
Compare
mxaddict
force-pushed
the
update-wallet-rpc-test
branch
from
a3a0c9d to
d4e0cf5
Compare
Contributor
Author
|
@aguycalled I've updated the commit |
mxaddict
changed the title
Contributor
Author
|
I updated the |
Member
|
restarting travis build to check it still passes |
Contributor
Author
|
The build failed, but due to memonic test, I've restarted the failed test. |
|
A new build of 62f6bb9 has completed succesfully! |
aguycalled
approved these changes
Nov 18, 2019
Contributor
Author
|
@proletesseract @chasingkirkjufell could you spare a moment to review the changes to the py tests on this PR? |
chasingkirkjufell
approved these changes
Nov 21, 2019
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
Contributor
There was a problem hiding this comment.
tested and code makes sense
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Nov 21, 2019
…eliable (navcoin#624) * Updates to make the wallet.py test more reliable * Updated qa/rpc-tests/stakeimmaturebalance.py to be more reliable
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Nov 21, 2019
…eliable (navcoin#624) * Updates to make the wallet.py test more reliable * Updated qa/rpc-tests/stakeimmaturebalance.py to be more reliable
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Dec 5, 2019
…eliable (navcoin#624) * Updates to make the wallet.py test more reliable * Updated qa/rpc-tests/stakeimmaturebalance.py to be more reliable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw these test was failing intermittently, I think this change will fix that.