This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
New API update #14
Merged
New API update #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now checks for status_code before parsing to json major refactor
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
===========================================
- Coverage 98.13% 81.05% -17.08%
===========================================
Files 1 5 +4
Lines 107 190 +83
Branches 22 31 +9
===========================================
+ Hits 105 154 +49
- Misses 0 25 +25
- Partials 2 11 +9
Continue to review full report at Codecov.
|
|
Tests will be done later. Merging now. |
|
@all-contributors please add @naveen521kk for code and docs and maintainer |
|
I've put up a pull request to add @naveen521kk! 🎉 |
|
@all-contributors please add @naveen521kk for maintenance projectManagement, review, test, platform |
|
I've put up a pull request to add @naveen521kk! 🎉 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is going to be a new update in sxcu.net API and it is waiting for this PR. So what's changed?
Introduced a logger class so that users can know what
really happened. User's can just set a logging handle and
it will automatically write logs as in any other library.
Improved Interface with Requests. Instead of Directly
calling it now logs them and goes through
__client.Moved version to
__version__and added other meta datato it.
Now it handle's server response codes. Previously it was
rising JSON decode Error which was unexpected and could cause
problems.
Finally written everything to changelog.