fix(text): Fix text position with candlestick type combination

- Update conditional to calculate text position only for data specified as candlestick - Split text test cases to separate file Fix #2436
naver · Nov 26, 2021 · f84ab3e · f84ab3e
1 parent 0278067
commit f84ab3e
Show file tree

Hide file tree

Showing 3 changed files with 1,382 additions and 1,300 deletions.
diff --git a/src/ChartInternal/internals/text.ts b/src/ChartInternal/internals/text.ts
@@ -339,9 +339,9 @@ export default {
 		let xPos = points[0][0];
 
 
-		if ($$.hasType("candlestick")) {
+		if ($$.isCandlestickType(d)) {
 			if (isRotated) {
-				xPos = $$.getCandlestickData(d)._isUp ?
+				xPos = $$.getCandlestickData(d)?._isUp ?
 					points[2][2] + 4 : points[2][1] - 4;
 			} else {
 				xPos += (points[1][0] - xPos) / 2;