Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read properties of null (reading 'sourceEvent') in device mode #2477

Closed
5r1m opened this issue Dec 28, 2021 · 2 comments
Closed

Cannot read properties of null (reading 'sourceEvent') in device mode #2477

5r1m opened this issue Dec 28, 2021 · 2 comments
Labels

Comments

@5r1m
Copy link

5r1m commented Dec 28, 2021

Description

There is uncaught exception when clicking on pie chart in device mode in chrome

Steps to check or reproduce

Screenshot 2021-12-28 at 1 31 03 PM

@5r1m
Copy link
Author

5r1m commented Dec 31, 2021

Problem seems to be in this handler:

const eventArc = getEventArc(event);

Unlike in mouse mode, event is not persisted in touch mode and adding below seems to fix the issue:
adding state.event = event;

@netil netil added the bug label Jan 3, 2022
@netil
Copy link
Member

netil commented Jan 3, 2022

Hi @5r1m, thanks for the report. I'll check the issue.

netil added a commit to netil/billboard.js that referenced this issue Jan 3, 2022
Add missing event value set to state

Ref naver#2477
@netil netil closed this as completed in d3d2e05 Jan 3, 2022
github-actions bot pushed a commit that referenced this issue Jan 5, 2022
# [3.3.0-next.2](3.3.0-next.1...3.3.0-next.2) (2022-01-05)

### Bug Fixes

* **event:** fix touch event handling on arc ([d3d2e05](d3d2e05)), closes [#2477](#2477)
* **types:** Fix plugin's type definition ([f3690f9](f3690f9)), closes [#2483](#2483)

### Features

* **axis:** alow user to hide tick lines while using culling ([aad8c45](aad8c45)), closes [#2478](#2478) [#2480](#2480)
* **bar:** Intent to ship bar.indices.removeNull ([b16605d](b16605d)), closes [#1687](#1687)
github-actions bot pushed a commit that referenced this issue Jan 14, 2022
# [3.3.0](3.2.2...3.3.0) (2022-01-14)

### Bug Fixes

* **api:** Ensure svg nodes to be removed from memory  ([f49ed83](f49ed83)), closes [#2489](#2489)
* **event:** fix touch event handling on arc ([d3d2e05](d3d2e05)), closes [#2477](#2477)
* **text:** Fix text position with candlestick type combination ([f84ab3e](f84ab3e)), closes [#2436](#2436)
* **tooltip:** fix candlestick tooltip display with xs option ([0278067](0278067)), closes [#2434](#2434)
* **types:** Fix axis types definition ([92fb033](92fb033)), closes [#2499](#2499)
* **types:** Fix plugin's type definition ([f3690f9](f3690f9)), closes [#2483](#2483)

### Features

* **axis:** alow user to hide tick lines while using culling ([aad8c45](aad8c45)), closes [#2478](#2478) [#2480](#2480)
* **bar:** add non zero based bar chart ([3588abe](3588abe)), closes [#2408](#2408) [#2438](#2438)
* **bar:** Implement stacking bar radius ([8f14d1a](8f14d1a)), closes [#2428](#2428)
* **bar:** Intent to ship bar.indices.removeNull ([b16605d](b16605d)), closes [#1687](#1687)
* **option:** Enhance padding to be removed completely ([2052a19](2052a19)), closes [#2367](#2367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants