Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After chart.destroy() all SVG objects. events etc... still exists but detached #2489

Closed
alexkzone opened this issue Jan 5, 2022 · 0 comments
Closed

After chart.destroy() all SVG objects. events etc... still exists but detached #2489

alexkzone opened this issue Jan 5, 2022 · 0 comments
Assignees
@netil
Labels
bug enhancement

Comments

@alexkzone
Copy link

Description

After I destroy the chart with the chart.destroy() command I open the debugger (I use Chrome) and "take heap snapshot" in "Memory" I see a lot of detached objects belong to the destroyed chart.
After a few iterations (create/destroy chart), it can cause the browser to freeze.

Steps to check or reproduce

Open one of the examples of chart
Add chart.destroy()
Open debugger
Run "take heap snapshot" and in class filter type "detached"
image

Thanks!
@netil netil self-assigned this Jan 12, 2022
netil added a commit to netil/billboard.js that referenced this issue Jan 13, 2022
@netil
fix(api): Ensure svg nodes to be removed from memory
853715c 
Instead of resetting by innerHTML, remove nodes to make sure
nodes to be removed from DOM tree.
Also, add unbind all attached events.

Ref naver#2489
@netil netil mentioned this issue Jan 13, 2022
Merged
@netil netil closed this as completed in f49ed83 Jan 13, 2022
github-actions bot pushed a commit that referenced this issue Jan 14, 2022
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
500e90b 
# [3.3.0](3.2.2...3.3.0) (2022-01-14)

### Bug Fixes

* **api:** Ensure svg nodes to be removed from memory  ([f49ed83](f49ed83)), closes [#2489](#2489)
* **event:** fix touch event handling on arc ([d3d2e05](d3d2e05)), closes [#2477](#2477)
* **text:** Fix text position with candlestick type combination ([f84ab3e](f84ab3e)), closes [#2436](#2436)
* **tooltip:** fix candlestick tooltip display with xs option ([0278067](0278067)), closes [#2434](#2434)
* **types:** Fix axis types definition ([92fb033](92fb033)), closes [#2499](#2499)
* **types:** Fix plugin's type definition ([f3690f9](f3690f9)), closes [#2483](#2483)

### Features

* **axis:** alow user to hide tick lines while using culling ([aad8c45](aad8c45)), closes [#2478](#2478) [#2480](#2480)
* **bar:** add non zero based bar chart ([3588abe](3588abe)), closes [#2408](#2408) [#2438](#2438)
* **bar:** Implement stacking bar radius ([8f14d1a](8f14d1a)), closes [#2428](#2428)
* **bar:** Intent to ship bar.indices.removeNull ([b16605d](b16605d)), closes [#1687](#1687)
* **option:** Enhance padding to be removed completely ([2052a19](2052a19)), closes [#2367](#2367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netil @alexkzone