feat(axis): alow user to hide tick lines while using culling #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ImADrafter, thanks for the contribution! |
|
Updated the option name from And also, the the newly added option should cover for y and y2 axes also. axis: {
[x | y | y2]: {
culling: {
max: 5,
lines: false // hide tick lines
}
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
# [3.3.0-next.2](3.3.0-next.1...3.3.0-next.2) (2022-01-05) ### Bug Fixes * **event:** fix touch event handling on arc ([d3d2e05](d3d2e05)), closes [#2477](#2477) * **types:** Fix plugin's type definition ([f3690f9](f3690f9)), closes [#2483](#2483) ### Features * **axis:** alow user to hide tick lines while using culling ([aad8c45](aad8c45)), closes [#2478](#2478) [#2480](#2480) * **bar:** Intent to ship bar.indices.removeNull ([b16605d](b16605d)), closes [#1687](#1687)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
# [3.3.0](3.2.2...3.3.0) (2022-01-14) ### Bug Fixes * **api:** Ensure svg nodes to be removed from memory ([f49ed83](f49ed83)), closes [#2489](#2489) * **event:** fix touch event handling on arc ([d3d2e05](d3d2e05)), closes [#2477](#2477) * **text:** Fix text position with candlestick type combination ([f84ab3e](f84ab3e)), closes [#2436](#2436) * **tooltip:** fix candlestick tooltip display with xs option ([0278067](0278067)), closes [#2434](#2434) * **types:** Fix axis types definition ([92fb033](92fb033)), closes [#2499](#2499) * **types:** Fix plugin's type definition ([f3690f9](f3690f9)), closes [#2483](#2483) ### Features * **axis:** alow user to hide tick lines while using culling ([aad8c45](aad8c45)), closes [#2478](#2478) [#2480](#2480) * **bar:** add non zero based bar chart ([3588abe](3588abe)), closes [#2408](#2408) [#2438](#2438) * **bar:** Implement stacking bar radius ([8f14d1a](8f14d1a)), closes [#2428](#2428) * **bar:** Intent to ship bar.indices.removeNull ([b16605d](b16605d)), closes [#1687](#1687) * **option:** Enhance padding to be removed completely ([2052a19](2052a19)), closes [#2367](#2367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes #2478
Details
Since I was the one who opened the issue I tried to figure out how could this feature should be implemented. Please let me know if either the feature is not necessary for the library or further changes are needed.