Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): Fix tooltip.format.value arg for bar range data #3517

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

netil
Copy link
Member

@netil netil commented Nov 8, 2023

Issue

#3507

Details

  • Make format function called once for range(array) data type
  • Update on defaultValueFormat to handle array type value also.
bb.generate({
  data: {
    columns: [
      ["data1", [100, 250], 30]
    ],
    type: "bar"
  },
  tooltip: {
    format: {
      value: function (value, ratio, id, index) {
        // when value is ranged type, "value" argument will be an array
        // x0: value => [100, 250]
        // x1: value => 30
      }
    }
  }
});

- Make format function called once for range(array) data type
- Update on defaultValueFormat to handle array type value also.

Ref naver#3507
@netil netil added the bug label Nov 8, 2023
@netil netil self-assigned this Nov 8, 2023
@coveralls
Copy link

Coverage Status

coverage: 94.354% (+0.001%) from 94.353%
when pulling b6ea783 on netil:tooltipValue#3507
into 048c4e2 on naver:master.

@netil netil merged commit c0f445e into naver:master Nov 8, 2023
10 checks passed
@netil netil deleted the tooltipValue#3507 branch November 8, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants