Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): fix candlestick tooltip display with xs option #2435

Merged
merged 1 commit into from
Nov 25, 2021
Merged

fix(tooltip): fix candlestick tooltip display with xs option #2435

merged 1 commit into from
Nov 25, 2021

Conversation

netil
Copy link
Member

@netil netil commented Nov 25, 2021 •
edited
Loading

Issue

#2434

Details

  • Make handling candlestick type shape in .findClosest()
  • Move .isWithinBar() from bar.ts -> shape.ts

@netil
fix(tooltip): fix candlestick tooltip display with xs option
d920260 
- Make handling candlestick type shape in .findClosest()
- Move .isWithinBar() from bar.ts -> shape.ts

Ref naver#2434
@netil netil added the bug label Nov 25, 2021
@netil netil self-assigned this Nov 25, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 90.068% when pulling d920260 on netil:candlestickTooltip#2434 into 70d2e35 on naver:master.

@netil netil merged commit 0278067 into naver:master Nov 25, 2021
@netil netil deleted the candlestickTooltip#2434 branch November 25, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@netil netil

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netil @coveralls