fix(types): Fix the type for options.data.names #2677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code supports setting a name to null to hide it from the legend. But type declarations were not allowing it.
|
@stof thanks for the contribution! |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
# [3.5.0-next.1](3.4.1...3.5.0-next.1) (2022-06-09) ### Bug Fixes * **bar:** fix bar radius for zero value ([9aa7579](9aa7579)), closes [#2642](#2642) * **build:** Fix this keyword transpile ([b65531a](b65531a)), closes [#2671](#2671) [#2664](#2664) [#2665](#2665) [#2666](#2666) [#2667](#2667) * **data:** Fix data label position on inverted axis ([b024d83](b024d83)), closes [#2700](#2700) * **grid:** Fix y grid to show for log axis type ([d0b8cbd](d0b8cbd)), closes [#2710](#2710) * **plugin:** fix sparkline dimension & tooltip ([79e1ab7](79e1ab7)), closes [#2682](#2682) * **plugin:** fix stanford tooltip formatting ([9a87464](9a87464)), closes [#2657](#2657) * **resize:** Fix legend resize ([7df949b](7df949b)), closes [#2650](#2650) * **scale:** fix getting tickOffset ([3091677](3091677)), closes [#2669](#2669) * **size.axis:** fix truncated axis when has no data ([40f4b66](40f4b66)), closes [#2675](#2675) * **types:** Fix `Chart.load({ json })` typing ([1bd4f4a](1bd4f4a)), closes [#2711](#2711) * **types:** Fix the signature of the tick format callback for timeseries ([c9c76e5](c9c76e5)), closes [#2676](#2676) * **types:** Fix the type for options.data.names ([e64f6bd](e64f6bd)), closes [#2677](#2677) * **types:** Fix types for the tooltip contents callback ([a0c0355](a0c0355)), closes [#2693](#2693) * **zoom:** fix wheel zoom feeling "stuck" when panning past the edge ([50ed640](50ed640)), closes [#2588](#2588) [#2648](#2648) ### Features * **data:** Intent to ship data.labels.rotate ([7b7ee08](7b7ee08)), closes [#2662](#2662) * **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202) * **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873) * **resize:** Intent to ship resize.timer ([#2712](#2712)) ([0a07de0](0a07de0)), closes [#2650](#2650)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
# [3.5.0](3.4.1...3.5.0) (2022-06-30) ### Bug Fixes * **bar:** fix bar radius for zero value ([9aa7579](9aa7579)), closes [#2642](#2642) * **build:** Fix this keyword transpile ([b65531a](b65531a)), closes [#2671](#2671) [#2664](#2664) [#2665](#2665) [#2666](#2666) [#2667](#2667) * **data:** Fix data label position on inverted axis ([b024d83](b024d83)), closes [#2700](#2700) * **grid:** Fix y grid to show for log axis type ([d0b8cbd](d0b8cbd)), closes [#2710](#2710) * **option:** Fix onresize/onresized call context ([3ef9684](3ef9684)), closes [#2726](#2726) * **plugin, type:** fix TextOverlap type definition ([80cc3b7](80cc3b7)) * **plugin:** fix sparkline dimension & tooltip ([79e1ab7](79e1ab7)), closes [#2682](#2682) * **plugin:** fix stanford tooltip formatting ([9a87464](9a87464)), closes [#2657](#2657) * **resize:** Fix legend resize ([7df949b](7df949b)), closes [#2650](#2650) * **scale:** fix getting tickOffset ([3091677](3091677)), closes [#2669](#2669) * **size.axis:** fix truncated axis when has no data ([40f4b66](40f4b66)), closes [#2675](#2675) * **types:** Fix `Chart.load({ json })` typing ([1bd4f4a](1bd4f4a)), closes [#2711](#2711) * **types:** Fix the signature of the tick format callback for timeseries ([c9c76e5](c9c76e5)), closes [#2676](#2676) * **types:** Fix the type for options.data.names ([e64f6bd](e64f6bd)), closes [#2677](#2677) * **types:** Fix types for the tooltip contents callback ([a0c0355](a0c0355)), closes [#2693](#2693) * **zoom:** fix wheel zoom feeling "stuck" when panning past the edge ([50ed640](50ed640)), closes [#2588](#2588) [#2648](#2648) ### Features * **area:** add option to render area below line ([cf60291](cf60291)), closes [#2740](#2740) [#2741](#2741) * **data:** Intent to ship data.labels.rotate ([7b7ee08](7b7ee08)), closes [#2662](#2662) * **option:** Intent to ship boost.useCssRule ([4a060d6](4a060d6)), closes [#2716](#2716) * **option:** Intent to ship boost.useWorker ([eeaf8bd](eeaf8bd)) * **resize:** Intent to ship resize.timer ([#2712](#2712)) ([0a07de0](0a07de0)), closes [#2650](#2650)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Details
The code supports setting a name to null to hide it from the legend. But type declarations were not allowing it:
billboard.js/src/ChartInternal/internals/legend.ts
Lines 460 to 462 in 9a87464