-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add type definition file #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienne Thank you!! For your PR. We are very appreciated to you!
Could you apply our review?
@tienne Maybe you missed it that I suggested following. export default Agent; instead of export = Agent; Could be possible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienne Thank you. I'll merge it!
@jongmoon |
@tienne It's distributed~ |
@jongmoon Thank you for letting me know. |
This PR is associated with issue #26
added a type definition file to enable @ egjs / agent in typescript.