Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add type definition file #27

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

tienne
Copy link
Contributor

@tienne tienne commented Nov 12, 2018

This PR is associated with issue #26
added a type definition file to enable @ egjs / agent in typescript.

@coveralls
Copy link

coveralls commented Nov 12, 2018

Coverage Status

Coverage remained the same at 93.525% when pulling 71fb953 on tienne:feature/type_definition into 9169cf7 on naver:master.

Copy link

@jongmoon jongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tienne Thank you!! For your PR. We are very appreciated to you!
Could you apply our review?

index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@jongmoon
Copy link

@tienne Maybe you missed it that I suggested following.

export default Agent;

instead of

export = Agent;

Could be possible?

Copy link

@jongmoon jongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tienne Thank you. I'll merge it!

@jongmoon jongmoon merged commit b8b4536 into naver:master Nov 13, 2018
@tienne tienne mentioned this pull request Nov 13, 2018
@tienne
Copy link
Contributor Author

tienne commented Nov 13, 2018

@jongmoon
Can you tell when the npm distribution will go into the merged version?
Thank you

@jongmoon
Copy link

@tienne We will distribute the merged version after #29 is done. (It would be done within 2 days)

@jongmoon
Copy link

@tienne It's distributed~

@tienne
Copy link
Contributor Author

tienne commented Nov 14, 2018

@jongmoon Thank you for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants